Audit signing protocol

[marsella]

Take a pass over the signing functions and identify concrete issues that should be addressed, according to the criteria in #272.

• [ ] Review signing functions
• [ ] Document findings and potential concerns
• [ ] Write specific issues