boltlabs-inc / tss-ecdsa

An implementation of a threshold ECDSA signature scheme
Other
12 stars 5 forks source link

Implement interactive signing #475

Closed marsella closed 1 year ago

marsella commented 1 year ago

Closes #467

This PR adds an implementation of interactive signing.

A couple discussion topics:

marsella commented 1 year ago

@gatoWololo I added said enum; there's a fairly ugly update method that I'd love your thoughts on. Updating a field in a mutable reference in-place is really awkward; I did it with a lot of mem::swaps

gatoWololo commented 1 year ago

@marsella Yeah, that's a hard one. Check out my branch: here I think it is slightly cleaner!

marsella commented 1 year ago

Thanks @gatoWololo, I like your version much better. This is now ready for re-review.