Closed marsella closed 1 year ago
@gatoWololo I added said enum; there's a fairly ugly update method that I'd love your thoughts on. Updating a field in a mutable reference in-place is really awkward; I did it with a lot of mem::swap
s
@marsella Yeah, that's a hard one. Check out my branch: here I think it is slightly cleaner!
Thanks @gatoWololo, I like your version much better. This is now ready for re-review.
Closes #467
This PR adds an implementation of interactive signing.
A couple discussion topics:
input
method onProtocolParticipant
wasn't being used in any protocol-participant-generic methods, so I removed it as a method on that trait. I did this because it doesn't make sense for this implementation to keep a separate copy of the private auxinfo and keygen material around in theInteractiveSignParticipant
; better to just pass it to the internalPresignParticipant
and wash our hands of it. However, that makes it hard to implement theinput()
method, so I removed it.Input
type here needs a proper constructor. I was thinking of doing that in a separate PR just because this one is already big (I haven't written that issue yet).