search

boltlabs-inc / tss-ecdsa

An implementation of a threshold ECDSA signature scheme
Other
11 stars 5 forks source link

add interactive signing public API #493

Closed marsella closed 11 months ago

marsella commented 11 months ago

Closes #426

This adds interactive signing to the public API. The only thing that had to change to make this possible was to add a condition that allows you to run a participant with ProtocolType = InteractiveSign.

The much larger change here is to add an interactive-sign end-to-end test. There's some duplicated code relative to the non-interactive-sign e2e test but I simplified some of the mechanics relative to the older test; I might try to consolidate that. There's a lot of duplication in general with running these protocols and it might be helpful to write a generic-over-protocol-type runner. But it also might be confusing.

Open to recommendations on simplifying the test, otherwise I can make an issue to clean up the end-to-end tests after also adding non-interactive sign to the public API (#494) and maybe when we pull out those tests to be actual integration tests (#428).

marsella commented 11 months ago

Made #496 to address code quality improvements in this test.