boltlabs-inc / tss-ecdsa

An implementation of a threshold ECDSA signature scheme
Other
11 stars 5 forks source link

Key Refresh protocol #522

Closed naure closed 4 months ago

naure commented 4 months ago

This is the first version of the Key Refresh protocol.


gatoWololo commented 4 months ago

It looks like the CI is failing due to formatting differences. You can always run cargo make ci to test this locally! (Assumes you have cargo make installed).

naure commented 4 months ago

Also fixed all linter errors.

I just figured out that the usual warnings from cargo and rust-analyzer don’t work with the specified rust version. I used this command to make it work again:

rustup override set nightly
naure commented 4 months ago

Overall, the code looks good. I just have some minor comments. I will say that I don't think the original paper updated rid with rho for key refresh, but updating rid with rho should not be problematic from a replay standpoint.

Indeed you're right. Should it just keep the old rid instead?

naure commented 4 months ago

The output now keeps the existing rid instead of the new one.