search

boltlabs-inc / zeekoe

Zero-knowledge layer-2 payment channels
MIT License
24 stars 1 forks source link

Complete manual testing of close flows #242

Closed marsella closed 3 years ago

marsella commented 3 years ago

Manually test the following flows to completion (e.g. both parties mark the channel as closed).

DariusParvin commented 3 years ago

@marsella. Dispute sometimes sometimes succeeds and sometimes fails. One possibility could be that it's to do with the way the contract converts bytes to fr. My understanding is that in zeekoe, large byte values for the revocation lock get wrapped around into a smaller fr value. In the smartpy script we use a trick for converting bytes to fr, which might not behave the same way as zeekoe.

Here are some values of revocation secret and revocation lock that succeeded/failed:

Succeeded

secret - 6b7444c8ae54df16e75f30c84f96146ca7e80a36a72f6ccf4125ca3ccfb4115e revocation lock - 5bda64ebfecaa0030a07af64bcd151e72ad9f8fc21b802094d6ceace6b28e373 https://granadanet.tzkt.io/KT1SrnWB3ydLiYk6Hd9zbjtGCx74QvNqh11K/operations/

secret - ed593cc537cb018bc8ed016b800a69e84aace5c2a499f43d7423193261a96c4b revocation lock - 0cc0f93979e3a1bbf3e17412347949c93823cda123134ff02b4fccb1be0f0830 https://granadanet.tzkt.io/KT1B1jGYZ1WcCmv4ZE8yxeNdfXdRWT5sRJG8/operations/

secret - 53411836bca769d5af3fe207b95a2575c776eac6ab2e25e8c46bd77d882c4f11 revocation lock - 73f4866d6ac7775de7533a6430b9ba2a2d66642ee4fe415e971d0d264b16b10a https://granadanet.tzkt.io/KT1Ez31q7gtXpCvRxzd4Usk4erGwA6riBgrE/operations/

Failed

secret - dc2aff71a1a2975e14301e50844064a0afb2a593ccc1460e4a0dd5bb36a7d744 revocation lock - dd6ecbe06960532183ad92dc095793ba937de478a6b14fbb24174c536f50ae4d https://granadanet.tzkt.io/KT1PTYZtx7g78aRDxAmx3PG2LVYq6ZXi5vrE/operations/

secret - 8400711a8290c6788a58d1cf5c97751b87bf898d448e923ce6fa9f5418ea0c17 revocation lock - 7faacce83438d951b9d9917c533c50620cd37f39714d5229091436e43663200b https://granadanet.tzkt.io/KT1WQeGRgKrAXRy7163Vhp5SNqWzEecrkzd1/operations/

secret - e998f4797d45dfc50e6f60127c5d49a704ad5bcaff8a85d9389e7e237d64ae5f revocation lock - 54e1c3d796ed39ff9f42190a2dea74331a173dd1395d946e06269148cc9c372f https://granadanet.tzkt.io/KT1KY9LC8UK2wGZoSpc4eDGEhFVA8PByqqbE/operations/

jakinyele commented 3 years ago

@DariusParvin what’s the status? Can we close?

DariusParvin commented 3 years ago

Yeah that's right. Each of the close flows has been tested. Closing this issue.