boltlabs-inc / zeekoe

Zero-knowledge layer-2 payment channels
MIT License
24 stars 1 forks source link

Improve tests #261

Closed DariusParvin closed 3 years ago

DariusParvin commented 3 years ago

this addresses #259

just to recap the two issues:

The second issue was more complicated than I anticipated because it's not just blocking on the while loop at L89 (which is easier to deal with), but .readline() is also blocking from within it's own subprocess. I think the proper solution to be able to run the merchant and customer daemons concurrently would involve setting up a queue to get outputs from .readline() without blocking.

Since that would take longer to figure out, I'm thinking for now at least to go with this simpler solution that requires setting up separate terminals for the customer and merchant. It might even be better this way since it's easier to read the output from each one?