boltlabs-inc / zeekoe

Zero-knowledge layer-2 payment channels
MIT License
24 stars 1 forks source link

automatically renaming channels during establishment #265

Closed DariusParvin closed 3 years ago

DariusParvin commented 3 years ago

With establish, if you try to create a channel with a name that’s already been used before, it’ll add a number at the end e.g. if you put in the name my-first-zkchannel and it’s already used, it’ll create a channel with the name my-first-zkchannel (1) .

I’m thinking this might not be such a great behavior because the user/program that gave the channel name might not be aware of the fact that a channel with a different name was created. It increases the chance of a user accidentally creating a duplicate channel, or paying on the wrong channel.

It may be better to return an error - ‘A channel with that name already exists’ instead?