boltlabs-inc / zeekoe

Zero-knowledge layer-2 payment channels
MIT License
24 stars 1 forks source link

channel status is `closed` instead of `dispute` #280

Closed DariusParvin closed 2 years ago

DariusParvin commented 2 years ago

When a channel is closed via a merch dispute, the channel should say disputed but instead it says closed.

marsella commented 2 years ago

The current flow has it move from Pending(customer)Close to Dispute to Closed, so the final status does not indicate that it was closed via dispute. The database saves both the balances that we tried to close on and the actual balances paid out on chain, so one could tell that it was closed via a dispute.

@indomitableSwan do you have any opinion on whether the final status for a disputed channel should be "Closed" vs "Closed-Dispute" ?

marsella commented 2 years ago

We will leave the final status as Closed and rely on the user to check the final paid-out balances to determine how much money they got back.