search

boltlabs-inc / zeekoe

Zero-knowledge layer-2 payment channels
MIT License
24 stars 1 forks source link

Remove new functions from Pay #333

Closed marsella closed 2 years ago

marsella commented 3 years ago

The timeout refactor from #311 added a bunch of functions to the pay protocol, but @yaymukund and I later decided to keep the long functions as-is and use async blocks in Establish and Close.

This issue can be closed when those single-use functions are removed from Pay and replaced with async blocks where necessary.

marsella commented 3 years ago

While testing to make sure that this refactor didn't break anything, I found that I introduced an error in #314. The error is that the merchant tries to load the tezos_client before the channel has been established and added to the database; this causes the merchant to abort early and the establish fails. I will fix this in the PR for this issue.

I did not find any errors introduced by this refactor.