Closed gijsvl closed 2 years ago
Review of the transport crate:
As discussed on slack, we might want to add a callback to the serve_while
function (e.g. a FnOnce
parameter) in order to allow custom logging or other administrative work once the server is running. However, I'm not sure if this would fix the logging issue we're seeing in tests (where we're currently filtering out non-zeekoe logs) because the log itself would be called from transport
-- you will have to check the log and see. Options if the filtering is still a problem:
It looks to me like there aren't major changes in the transport crate except maybe adding an Address
trait. Is there anything else specific that you'd like me to look at?
With regard to the transport crate, indeed, not much changed, it's basically the same with the exception of the abstract Trait Address
, as you've mentioned.
Before merging, we should merge https://github.com/boltlabs-inc/transport/pull/1, and change the transport dependency back to "main" branch
The extracted transport crate can be found here: https://github.com/boltlabs-inc/transport
We should make sure it all still makes sense, including the level of abstraction. Specifically, the feature
allow_explicit_certificate_trust
, does that make sense to also live inside the transport crate, I do believe so, but just checking. Also, the abstraction forZkChannelAddress
that now implements the traitAddress
, which is part of the transport crate.