Closed johnlister closed 1 year ago
Thanks for the PR! 😄
Ran the terraspace acceptance tests pipeline on it. Annoyingly, this slight change breaks terraspace all
🤦🏻♂️
Pipeline with boltops-tools master (passes)
Pipeline with johnlister fork (fails)
Took a look at the terraspace all
codebuild logs and sadly it didn't help much. Will have to try to improve the TSC logging when get a chance.
Will have to dig into this more when get a chance. If you get to it before me, much appreciated! No sweat either way of course 👍
Here's the build script https://github.com/boltops-tools/terraspace/blob/master/.cody/all/bin/build.sh The particularly test checks that https://github.com/boltops-tools/terraspace-graph-demo still works. Will have to just clone it down locally and test to investigate further.
I'll have a look, to be honest didn't run terraspace all locally after applying it. Suspect something relies on an empty file?
RE: Suspect something relies on an empty file?
Guessing the same thing.
Odd, just ran it locally on my branch and it succeeded - only change I made to the demo graph was to use a local backend, applied the change to your latest master branch and it failed, but re-running a second time passed. Couldn't see any empty files in the demo... Will re-look later
Bummer 😒 Thanks for the update.
Ran the pipeline again and it passed this time. It may be something intermittent 🤦🏻♂️ Merging as-is.
Released in 2.2.3
bundle exec rspec
to verify this)Summary
Fixes https://github.com/boltops-tools/terraspace/issues/284
How to Test
Version Changes
patch