boltops-tools / terraspace

Terraspace: The Terraform Framework
https://terraspace.cloud
Apache License 2.0
674 stars 46 forks source link

Only generate output files with content #285

Closed johnlister closed 1 year ago

johnlister commented 1 year ago

Summary

Fixes https://github.com/boltops-tools/terraspace/issues/284

How to Test

Version Changes

patch

tongueroo commented 1 year ago

Thanks for the PR! 😄

Ran the terraspace acceptance tests pipeline on it. Annoyingly, this slight change breaks terraspace all 🤦🏻‍♂️

Pipeline with boltops-tools master (passes)

terraspace pipeline good master

Pipeline with johnlister fork (fails)

terraspace pipeline broken pr

Took a look at the terraspace all codebuild logs and sadly it didn't help much. Will have to try to improve the TSC logging when get a chance.

terraspace codebuild terraspace all logging

Will have to dig into this more when get a chance. If you get to it before me, much appreciated! No sweat either way of course 👍

Here's the build script https://github.com/boltops-tools/terraspace/blob/master/.cody/all/bin/build.sh The particularly test checks that https://github.com/boltops-tools/terraspace-graph-demo still works. Will have to just clone it down locally and test to investigate further.

johnlister commented 1 year ago

I'll have a look, to be honest didn't run terraspace all locally after applying it. Suspect something relies on an empty file?

tongueroo commented 1 year ago

RE: Suspect something relies on an empty file?

Guessing the same thing.

johnlister commented 1 year ago

Odd, just ran it locally on my branch and it succeeded - only change I made to the demo graph was to use a local backend, applied the change to your latest master branch and it failed, but re-running a second time passed. Couldn't see any empty files in the demo... Will re-look later

tongueroo commented 1 year ago

Bummer 😒 Thanks for the update.

tongueroo commented 1 year ago

Ran the pipeline again and it passed this time. It may be something intermittent 🤦🏻‍♂️ Merging as-is.

pipeline success

tongueroo commented 1 year ago

Released in 2.2.3