search

boltpkg / bolt

⚡️ Super-powered JavaScript project management
MIT License
2.35k stars 82 forks source link

chore: drop support for node 4 #243

Closed ForbesLindesay closed 5 years ago

ForbesLindesay commented 5 years ago

The build is currently failing anyway, and node 4 has been unsupported for ages. This would save contributors time spend on trying to figure out why their PR is failing.

lukebatchelor commented 5 years ago

Sweet, cheers for the PR. I'm completely in favour of this personally. I don't see it being controversial, so happy to merge it soon if I don't hear back from @jamiebuilds .

Would you mind updating the error message in bin.js too though?

if (majorVer < 4) {
  throw new Error(
    'Node version ' +
      ver +
      ' is not supported in Bolt, please use Node.js 4.0 or higher.'
  );
}
lukebatchelor commented 5 years ago

Thanks heaps for the contribution @ForbesLindesay , the change has been done in #246 now, which should be released today (sorry, didn't think to cherry pick your commit 🤦‍♂ ).

Will update with which version this releases in.

lukebatchelor commented 5 years ago

Released in 0.24.0