search

boltpkg / bolt

⚡️ Super-powered JavaScript project management
MIT License
2.34k stars 84 forks source link

Always symlink internal dependencies even if they already exist #307

Closed Blasz closed 2 years ago

Blasz commented 2 years ago

Internal dependency symlinks can become stale if the dependency changes paths in the repo so its best to always recreate them for robustness. The performance cost of this change isn't too bad as the majority of the symlinking slowdown is caused by the .bin symlinking.

Locally in atlassian-frontend this takes about 5 seconds longer but the variance between installs can be more than 5 seconds so its hard to measure the performance impact. On CI the performance was the same.

Removing the existing symlink check blows out local installs from ~30s to ~90s which verifies that the bin symlinks are the slowdowns (which makes sense as its symlinking all the bins of the entire project for each package in the repo regardless of its declared dependencies).

lukebatchelor commented 2 years ago

cc: @jonathancreamer-eb Heya, just a heads up that this affects your recent optimization in #286 . Does this look okay to you?

jcreamer898 commented 2 years ago

Yeah I'm sure for internal it probably doesn't change perf too much. Thanks for the heads up!

lukebatchelor commented 2 years ago

Released in v0.24.10