search

bombbomb / BBCore

A Javascript API to use BombBomb services
4 stars 12 forks source link

Replaces $ with jQuery to add support for applications that use jQuery.noconflict mode. Quick fix for #3 #4

Closed benwells closed 8 years ago

benwells commented 8 years ago

In order to go into production with a bbcore.js integration next week, we have had to download and perform the following modification on bbcore.js so that the library works with jQuery's noconflict mode.

Since this version of bbcore.min.js has worked for us and you might have other customers trying to use applications that don't attach jQuery to $, I wanted to put this PR out there to try and help. This "quick fix" would get those customers up and running quickly while you continue to replace $.extend and $.ajax as the long term solution.

I ran both grunt and grunt full before committing. This version of bbcore.min.js has also passed our internal QA and testing process as we are using it in our application.

I did notice that grunt also generated a bbcore.combined.js file, but I did not commit this file since it didn't exist in master when I forked the repo.

If you choose to accept this PR and there are additional build steps that need to be performed, just let me know and I'm happy to follow process/write tests/etc...

perl5punk commented 8 years ago

Ben, Thanks for this request,everything looks good. I just need to run through one more thing from our side. Otherwise, our build sets are automated, so that's not a problem so I'll merge this shortly.

Cheers, Brian

benwells commented 8 years ago

Cool, thanks Brian!