search

bombela / backward-cpp

A beautiful stack trace pretty printer for C++
MIT License
3.73k stars 471 forks source link

TraceResolverImpl<system_tag::windows_tag>::resolve marked override breaks MSVC build #208

Closed taidg closed 3 years ago

taidg commented 3 years ago

TraceResolverImpl does not inherit from a base class, but as of https://github.com/bombela/backward-cpp/pull/162 the resolve method is marked override, causing a compiler error.

Either the class should inherit from a base class or the recently added override should be removed.

taidg commented 3 years ago

Looks like removing it does not work, only adding the base class TraceResolverImplBase