Closed blacktea closed 3 years ago
Hi, @bombela, is there any wrongs with the MR? Should I provide more clarifications(examples or smth like that)?
Nothing wrong. I am just a lazy open source maintainer. You raise a good point on the override of non-virtual methods.
This MR fixes stack trace under Windows. For example run
test_suicide
test. Stack trace Before:There are no names of method.
After:
Now we can see places of recursion (
bye_bye_stack
).Reason: Context is set at https://github.com/bombela/backward-cpp/blob/master/backward.hpp#L4432. But later context is rewritten in
load_here
method https://github.com/bombela/backward-cpp/blob/master/backward.hpp#L1120.It's a not good idea to override non-virtual method of the base class https://github.com/bombela/backward-cpp/blob/master/backward.hpp#L1114, https://github.com/bombela/backward-cpp/blob/master/backward.hpp#L752, https://isocpp.org/wiki/faq/strange-inheritance#redefining-nonvirtuals.