bomberstudios / sketch-commands

A collection of script commands for Sketch.app
822 stars 50 forks source link

Update project structure to follow new Sketch plugin guidelines #60

Closed guerrero closed 8 years ago

guerrero commented 8 years ago

Inspired by this repo, I'm creating my own commands and most of them have been borrowed from yours so, if you're interested, I can create a PR to update this repo structure. Some of these changes would be:

bomberstudios commented 8 years ago

That sounds awesome, and it's something I'd do myself if I had the time, so I'll happily merge a pull request with these changes from you : )

guerrero commented 8 years ago

Done :) #61

bomberstudios commented 8 years ago

Awesome! Will review and merge in a minute : )

guerrero commented 8 years ago

@bomberstudios Great! Thanks for your support, also I've seen some other changes that can be done to improve the repo and save some lines of code. Some of them are the following:

I've also other recommendations and propositions, like use dot notation to support linting tools, but I don't know if you're interested and I don't want to be like a spammer opening a lot of issues at the same time so, if you wish, I can proceed creating some issues.

Thanks!

bomberstudios commented 8 years ago

Delete sandbox file and modify files that uses sandbox methods

Just did this locally, so I'll take it and will push in a minute.

The rest look reasonable, and I'd love to get pull requests for them : )

guerrero commented 8 years ago

Nice! I'll create them in the next few days.

P.S. Thanks to mention me in your README's Thanks section!

bomberstudios commented 8 years ago

P.S. Thanks to mention me in your README's Thanks section!

It's the least I could do!