search

bomberstudios / sketch-commands

A collection of script commands for Sketch.app
822 stars 50 forks source link

Fixes "Export Page to ..." errors #75

Closed bre7 closed 7 years ago

bre7 commented 7 years ago

Closes #71

Fixes totalRectForLayers / requestWithRect_scale errors

ToDo: Refactor code to Utils

bre7 commented 7 years ago

Can we use artboards() instead of children() ?

bomberstudios commented 7 years ago

Can we use artboards() instead of children() ?

You're assuming that

  1. the page will always contain artboards
  2. the page will contain nothing but artboards

both of which are certainly not true all of the time : )

Thanks for the PR, will merge as soon as I finish reviewing it!

bre7 commented 7 years ago

👌 true.

I’ll push an update to the manifest.json to support auto-update (I bet it can be automated, if needed)

bomberstudios commented 7 years ago

Awesome, thanks!