search

bomberstudios / sketch-framer

A Sketch plugin to easily export your mockups to FramerJS
Other
767 stars 67 forks source link

Border set to 'outside' bubbles up to parent group #41

Closed jenbennings closed 10 years ago

jenbennings commented 10 years ago

Took me a while to figure out what was going on here. Basically, a border set to 'outside' on a child group (or element) is resulting in erroneous width/height on the parent group. This is only visible in the .png output. Here's an example:

The pink view is 640px × 1136px. However since I have a child group with an outside border thickness of 50px, it has exported out as 740px × 1236px (an extra 50px on each side).

Not quite sure if this is something to do with Sketch, Sketch Framer, or me!

bomberstudios commented 10 years ago

Actually, I'm not sure if it's Sketch, Sketch Framer or Framer.js, but I'm 100% sure it's not you, because I got the same report from another source : )

Thanks for the detailed explanation, this will really help find the problem!

bomberstudios commented 10 years ago

Actually, this is a duplicated of #31, so I'm closing this one : )

cemre commented 10 years ago

@jenbennings Jen, I work around this by using Flatten selection to Bitmap