search

bomberstudios / sketch-framer

A Sketch plugin to easily export your mockups to FramerJS
Other
767 stars 67 forks source link

Mask without fill borks dimensions of layer contents #76

Closed koenbok closed 9 years ago

koenbok commented 10 years ago

A layer that is masked has the wrong frame. If you add a fill to the mask it gets the correct frame.

Sketch: http://cl.ly/2Y0O2B3O2e3G

image

koenbok commented 10 years ago

Yes so the mask here is bigger than the image, so the layer gets the maskFrame. We should correct for this in the importer code.

benjamindenboer commented 9 years ago

Further analysis:

(Sketch + Framer File: http://cl.ly/Zm14)

bounds1 bounds2

koenbok commented 9 years ago

Simpler version of this issue: http://share.framerjs.com/x43u2ze0z2xo/

Repro: create a layer group with a mask that is larger than the contents and had no fill.

koenbok commented 9 years ago

This also fixes https://github.com/bomberstudios/sketch-framer/issues/83

koenbok commented 9 years ago

Fixed verified.