bomberstudios / sketch-framer

A Sketch plugin to easily export your mockups to FramerJS
Other
767 stars 67 forks source link

Importing with unsaved Sketch file in background #89

Open benjamindenboer opened 9 years ago

benjamindenboer commented 9 years ago

When trying to import a saved, active file while having an unsaved document in the background, Sketch and Framer both throw errors and the import fails.

sketchim

imf

Not necessarily a big issue. But it should be possible to import a valid, saved and active document regardless of what documents you have opened in the background.

bomberstudios commented 9 years ago

Can't reproduce here, is this still an issue, @benjaminnathan and @koenbok?

koenbok commented 8 years ago

Yes this is actually a Sketch issue. Repro:

You now get a bunch of warnings. Apparently Sketch still thinks the minimized document is the frontmost one.

bomberstudios commented 8 years ago

I think that's actually a new issue in Sketch (context.document points to the wrong thing under some circumstances, like following the steps you outlined) and is technically not related to save state. Anyway, we're about to fix it so those steps are really handy to reproduce the issue : )

bomberstudios commented 8 years ago

This is fixed in Sketch 3.4.2 15853 (a beta is coming out shortly). I'll leave this open until you can confirm the fix : )

bomberstudios commented 8 years ago

Ping @benjaminnathan and @koenbok: did you have a chance to try the latest Sketch beta? I'd love to confirm this issue has been fixed for good : )

koenbok commented 8 years ago

I think I just saw this again :-/

koenbok commented 8 years ago

Basically Sketch still seems confused if:

bomberstudios commented 8 years ago

: (