search

bomberstudios / sketch-framer

A Sketch plugin to easily export your mockups to FramerJS
Other
767 stars 67 forks source link

Improve scaled artboard situation #96

Closed koenbok closed 8 years ago

koenbok commented 9 years ago

Since Sketch switched to points vs. pixels, we have a lot of people confused when exporting them.

@benjaminnathan explains it best here: https://www.facebook.com/groups/framerjs/permalink/691634997630241/

How could we make this more straight forward?

References: https://www.facebook.com/groups/760188533992744/permalink/998374860174109/ https://www.facebook.com/groups/framerjs/permalink/683194658474275/ https://www.facebook.com/groups/framerjs/permalink/641286459331762/ https://www.facebook.com/groups/framerjs/permalink/640739382719803/

patrickkeenan commented 9 years ago

For all my prototypes I define scale(S=3) at the beginning of my code. Then whenever I have a unit I use 360*S. It's painful. I would recommend using density independent pixels like the Google material spec. This makes it easy to work at any density. Maybe it could be a Framer global variable?

mrrocks commented 9 years ago

Actually, if you set a different size (2x, 3x, etc) for your assets, they actually get exported to Framer at that specific size. The real problem is positions (x, y), they remain at 1x on the JSON file.

koenbok commented 9 years ago

Thanks for the input!

koenbok commented 8 years ago

Also be sure to check out @peteschaffners pull request: https://github.com/koenbok/Framer/pull/228

bomberstudios commented 8 years ago

This would be solved nicely by #103, so maybe this one can be closed?