fix kernel_logger_name with /permisive-

bombomby / optick

C++ Profiler For Games

https://optick.dev

MIT License

2.95k stars 296 forks source link

fix kernel_logger_name with /permisive- #80

Closed malytomas closed 5 years ago

malytomas commented 5 years ago

Hi again, I apologize for the forgotten (LPSTR) cast hotfix that has sneaked into my previous PR :( Anyway, when compiling with /permisive-, which forces visual studio to be more conformant with c++ standard, it fails on assigning const pointer to non-const variable. This PR does a proper fix. There are also few fixed line endings. I hope that is ok.

BrodyHiggerson commented 5 years ago

@bombomby is it possible to merge this or https://github.com/bombomby/optick/pull/87? :)

malytomas commented 5 years ago

This has been fixed in the master branch. Closing the pull request.

bombomby commented 5 years ago

Yep, sorry, forgot to close this one. Unfortunately due to the required support for some ancient msvc compilers (VS2012 in particular) I can't use decltype, so had to add a slightly different fix.