search

bombshell-dev / clack

Effortlessly build beautiful command-line apps
https://clack.cc
5.26k stars 88 forks source link

fix(@clack/prompts): note title correctly evaluates title length with ansi #119

Closed SimeonC closed 11 months ago

SimeonC commented 1 year ago

The bug is caused when a title has ansi characters. In my case it was when I used chalk in both the title and note which caused the below screenshot.

Before this change; CleanShot 2023-04-17 at 14 11 42

After change; CleanShot 2023-04-17 at 14 11 59

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ab51d29128ffb99c1fd94a08cf6ae120643d7e4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @clack/prompts | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

SimeonC commented 1 year ago

@natemoo-re What am I missing to get a review/approval on this PR?

ConProgramming commented 11 months ago

@natemoo-re would love to have this