Open Mist3rBru opened 11 months ago
Latest commit: 3174ccffe813b0f0595fe80bf8cc72c68b56e914
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@Mist3rBru Great Work 🙏🏼 ,
I actually kinda of like this.. This could be a great addition. I'm just not for sure on the namespace builder
. It almost sounds to me like a workflow
. What are your thoughts?
I also think, within the next couple of releases -- I want to focus on knocking out a few bugs reported, then exposing each individual core
prompt interface types to make it agnostic vs duplicating types that are already exist in core
. This way someone can easily build on top of core as an agnostic layer like what we do for @clack/prompts
. Then we can add another layer for themes etc.
Thanks, CP 🚀
I agree, sounds more like an workflow
, it could also change the add
method to step
.
Example:
await p.workflow()
.step('name', () => p.text())
.run()
@Mist3rBru I like that.
My only questions here
groups
in favor on this ? group
a end user might ask Which one do I use ?
We can release it, and open a pinned issue like v1.0.0 Roadmap, so people can give their thoughts, and we decide based on it.
I think it is a better API, since it does not deal with inference errors, and is more extensible.
@Mist3rBru I made some improvements to examples please check this out: https://github.com/natemoo-re/clack/commit/de9f5b6c7f92237189972f185b24d7128434f7d4
@cpreston321 commit included.
This helps a lot to run the examples!
Since Typescript has shown a limitation on infer
group
results, discussed in @chrissantamaria's comment on PR#102, and Issue #131. This functionality presents an alternative for users who favor the builder pattern when dealing with multiple prompts in sequence, serving as either a workaround or an additional choice, while avoid a breaking change.This PR includes:
I am open to discussions on comment's section!
Closes #131 Closes #109