Closed Mist3rBru closed 10 months ago
Latest commit: 3c739f060281cecb81fcfea5646e343696e9f2da
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Hey @Mist3rBru! Everything looks good besides the the submitted value. The old way would show something like this @scope/a, @scope/b, @scope/c, @scope/z
.
vs
@cpreston321 This is from main branch, I did not changed this (state) behavior.
@Mist3rBru Screenshot 1 was from main branch and screenshoot 2 was from your branch.
try it out in both: pnpm dev
@cpreston321 the screenshots are testing different cases, the main:line#62 is concatenating the result with \n
on patch step, I can change it, but I did't it.
@Mist3rBru I thought it more of a symptom more then a test case. Since the maxItems was moved to a single function.
So I figured it was it was a side effect. I don't think it was intentional on your side.
@cpreston321 it is fine 😄. I gonna change this patch result to match multiselect result
LGTM @Mist3rBru thanks for the PR!
🚀
This PR this introduces maxItems option to
multiselect
prompt, using the same logic asselect
prompt. Now both use the same utility function limitOptions that handles this logic.Demo
https://github.com/natemoo-re/clack/assets/100330057/6e8ebb80-3070-4028-aacb-68d206a99f99