fix(@clack/prompts): clear `spinner`'s hooks on `spinner.stop`

bombshell-dev / clack

Effortlessly build beautiful command-line apps

https://clack.cc

5.23k stars 88 forks source link

fix(@clack/prompts): clear `spinner`'s hooks on `spinner.stop` #155

Closed Mist3rBru closed 10 months ago

Mist3rBru commented 10 months ago

This PR adds registration and clear steps to spinner's hooks

changeset-bot[bot] commented 10 months ago

🦋 Changeset detected

Latest commit: 50ed94aad1e99f60db98b27ee072a1614e30e48c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | @clack/prompts | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mist3rBru commented 10 months ago

@mikenikles may you test this fix? I could not reproduce the error 😕.

mikenikles commented 10 months ago

Beautiful 😍! That works exactly as expected. I was half-way through creating a bug ticket, but I won't bother finishing that given it's already fixed.

Thanks a million 🙏!

Mist3rBru commented 10 months ago

Awesome @mikenikles! Thank you for your report 😄.

And don't bother about creating issue reports, they are our opportunities to improve the package.

BryceBarbara commented 8 months ago

@Mist3rBru any idea when a new release will be cut? I'd really appreciate being able to use this fix as it's currently what is needed to fix my CLI.

Mist3rBru commented 8 months ago

Hey @BryceBarbara! This release could be managed by @cpreston321; however, it appears that he has been inactive for some time, and it's possible that he is awaiting a return of @natemoo-re along with some other dependencies.

cpreston321 commented 8 months ago

Hello @Mist3rBru!

I am actually awaiting for some feedback from @natemoo-re! I haven't heard that much from him since he is full time working on Astro.

Once he gives me the go head - I will trigger next release. I just want to make sure we are align on the merges so far.

Thanks, CP

natemoo-re commented 8 months ago

Thanks for the ping, y'all! Sorry I've been MIA. Hoping to onboard some additional maintainers soon and get back on top of things here.