feat: add select-key option

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: d74dd05cfc180fd8a0887b1f62ba20f0b2588fc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | -------------- | ----- | | @clack/prompts | Minor | | @clack/core | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[songkeys]

I just checked. LGTM!

One unimportant thing: do you think the gray letter boxes that are vertically attached may confuse users? Would it better and capable to split them with 1px gaps so that they are horizontally linked with the same-line text in visual.

[ulken]

I see your point, but AFAIK 1 px gaps are hard to achieve in a terminal. You have spaces and newlines to work with.

[ulken]

Would enclosing the hotkeys in brackets (may be some better Unicode ones) make them resemble a key more?

[songkeys]

Would enclosing the hotkeys in brackets (may be some better Unicode ones) more clearly resemble a key?

Yes i do think so. It'd be like:

- [y] yes
- [n] no
- [r] regenerate

But the gray boxed one are cute. I'm not sure. It

---

And I think I forgot one feature here: the default selection which should be displayed in one uppercased letter. e.g.

- [Y] yes
- [n] no
- [r] regenerate

when hitting enter, it selects yes by default.

[ulken]

But the gray boxed one are cute. I'm not sure.

I agree, but I was thinking both.

And I think I forgot one feature here: the default selection which should be displayed in one uppercased letter. e.g.

- [Y] yes

- [n] no

- [r] regenerate

when hitting enter, it selects yes by default.

I think I'd prefer a higher contrast color instead.

[songkeys]

bracked letter in a gray box + default one in a higher contrasted color box.

great idea!

[MendyLanda]

Hi, thanks for this PR.

I think I'd prefer a higher contrast color instead.

Here's what it could look like:

To my eyes, adding a default 'selected' highlight also makes it easier to differentiate from the other rows (regardless of the fact that in the example it's in the middle)

[ulken]

Just to put more options on the table, here are renderings of brackets in play:

Outer padding

Inner padding

No padding

Thoughts?

[ulken]

Yet another option:

I'm leaning towards this one. IMO, the brackets made it too clumsy, but I think the subtle hint adds value without ruining the aesthetics.

[songkeys]

I don't have any preference with the three options above as long as there are brackets inside the box. @ulken 's proposal doesn't solve the problem that the letter in the box doesn't look like a "shortcut key" to me at the first glance. But it might be just me cuz I used to see them in brackets.

How about a poll on twitter if you couldn't decide?

[ulken]

More subtle active style (with brackets back in place):

[ulken]

@natemoo-re all right, I think we're good to go here, no?

@Songkeys sorry, @natemoo-re seemed to prefer it without brackets (as do I).