bombshell-dev / clack

Effortlessly build beautiful command-line apps
https://clack.cc
5.53k stars 90 forks source link

chore: move unbuild to the root `package.json` #91

Closed privatenumber closed 1 year ago

privatenumber commented 1 year ago

unbuild is used by all the packages so it doesn't need to be a dev-dependency in all of them—just the root is fine.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 45eb8f7ff1d05bdb42eee49c85b5afea2866c972

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ulken commented 1 year ago

On a related note: would probably be good to put together a CONTRIBUTING.MD of what's expected in/by a PR.

// cc @natemoo-re

ulken commented 1 year ago

bundledDependencies -> devDependencies, but yeah.

On March 3, 2023, "dependabot[bot]" @.***> wrote:

@.**** commented on this pull request.


In packages/prompts/package.json https://github.com/natemoo-re/clack/pull/91#discussion_r1124054684:

@@ -57,7 +57,6 @@ "sisteransi": "^1.0.5" }, "devDependencies": {

  • "unbuild": "^1.1.1", "is-unicode-supported": "^1.3.0"

I plan on addressing that too. It should definitely not be in bundledDependencies.

— Reply to this email directly, view it on GitHub https://github.com/natemoo-re/clack/pull/91#discussion_r1124054684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD6DRNOKDVWE2AX4Z6MNETW2GCKNANCNFSM6AAAAAAVM2MNM4 . You are receiving this because you modified the open/close state.Message ID: @.***>

ulken commented 1 year ago

Hum, giving it a second thought, it might not be needed in the dist since it is only used to define values of constants, i.e. shouldn’t be needed at runtime? Or am I wrong?

On March 3, 2023, "Oskar Löfgren" @.***> wrote:

bundledDependencies -> devDependencies, but yeah. On March 3, 2023, "dependabot[bot]" @.***> wrote:

@.**** commented on this pull request.


In packages/prompts/package.json https://github.com/natemoo-re/clack/pull/91#discussion_r1124054684:

@@ -57,7 +57,6 @@ "sisteransi": "^1.0.5" }, "devDependencies": {

  • "unbuild": "^1.1.1", "is-unicode-supported": "^1.3.0"

I plan on addressing that too. It should definitely not be in bundledDependencies.

— Reply to this email directly, view it on GitHub https://github.com/natemoo-re/clack/pull/91#discussion_r1124054684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD6DRNOKDVWE2AX4Z6MNETW2GCKNANCNFSM6AAAAAAVM2MNM4 . You are receiving this because you modified the open/close state.Message ID: @.***>

ulken commented 1 year ago

Yeah, strike that. Of course it’s needed at runtime (to determine if the terminal it’s run in supports it or not).

Still early morning over here…

On March 3, 2023, "Oskar Löfgren" @.***> wrote:

Hum, giving it a second thought, it might not be needed in the dist since it is only used to define values of constants, i.e. shouldn’t be needed at runtime? Or am I wrong?

On March 3, 2023, "Oskar Löfgren" @.***> wrote:

bundledDependencies -> devDependencies, but yeah. On March 3, 2023, "dependabot[bot]" @.***> wrote:

@.**** commented on this pull request.


In packages/prompts/package.json https://github.com/natemoo-re/clack/pull/91#discussion_r1124054684:

@@ -57,7 +57,6 @@ "sisteransi": "^1.0.5" }, "devDependencies": {

  • "unbuild": "^1.1.1", "is-unicode-supported": "^1.3.0"

I plan on addressing that too. It should definitely not be in bundledDependencies.

— Reply to this email directly, view it on GitHub https://github.com/natemoo-re/clack/pull/91#discussion_r1124054684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD6DRNOKDVWE2AX4Z6MNETW2GCKNANCNFSM6AAAAAAVM2MNM4 . You are receiving this because you modified the open/close state.Message ID: @.***>