Fix line duplication bug with proper line wrapping

[natemoo-re]

Closes #87.

• Bundles wrap-ansi. Kind of a bummer, but it's battle-tested and works very well. Ideally we'll continue exploring our own, smaller version on the feat/wrap branch.
• Automatically wraps prompts to properly calculate visual line offset for each frame
• Also re-wraps the previous frame in case the columns have changed. This allows the line calculation to stay up-to-date.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 58a1df115024788d43a19977768ebdaf43e752e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | -------------- | ----- | | @clack/core | Patch | | @clack/prompts | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ulken]

@natemoo-re the release build seem to have failed. Did we (I) break something by merging https://github.com/natemoo-re/clack/pull/91 or https://github.com/natemoo-re/clack/pull/95?

The latter seems more likely if so. Removing the build command seems suspicious. Is prepack not run when/as expected after all?

There were questions around your previous change there so probably related.

[ulken]

// cc @privatenumber

[ulken]

Potentially related and maybe what @natemoo-re followed?

https://github.com/changesets/changesets/issues/837#issuecomment-1222206876

[ulken]

Still don't understand why prepack is not called, though.

pnpm publish should trigger it if I understand this correct? https://pnpm.io/cli/publish

and changesets seem to use it if installed?

https://github.com/changesets/changesets/blob/5c53bff0efeb5bbd72976b79aefe9d5805038ebd/packages/cli/src/commands/publish/npm-utils.ts#L156

[ulken]

Should probably revert in the meantime?

[natemoo-re]

@natemoo-re the release build seem to have failed. Did we (I) break something by merging https://github.com/natemoo-re/clack/pull/91 or https://github.com/natemoo-re/clack/pull/95?

The latter seems more likely if so. Removing the build command seems suspicious. Is prepack not run when/as expected after all?

There were questions around your previous change there so probably related.

Ah whoops! I pressed merge and then stepped out. My bad! I'll have to look into what happened here.

[natemoo-re]

I think https://github.com/natemoo-re/clack/commit/a7e6a5a6bcc7e8aa86de29b82f5378fee4b133fe should fix it. I haven't used prepack before, maybe changesets doesn't automatically call it...?

[ulken]

@natemoo-re the release build seem to have failed. Did we (I) break something by merging https://github.com/natemoo-re/clack/pull/91 or https://github.com/natemoo-re/clack/pull/95?

The latter seems more likely if so. Removing the build command seems suspicious. Is prepack not run when/as expected after all?

There were questions around your previous change there so probably related.

Ah whoops! I pressed merge and then stepped out. My bad! I'll have to look into what happened here.

If anyone should apologize, it's me.

[ulken]

I think https://github.com/natemoo-re/clack/commit/a7e6a5a6bcc7e8aa86de29b82f5378fee4b133fe should fix it. I haven't used prepack before, maybe changesets doesn't automatically call it...?

Right, but prepack is one of many lifecycle scripts called by the package manager. pnpm supports them too.

[ulken]

And judging by the code changesets seems to invoke the underlying package manager.

[ulken]

Let's leave it at this for now. @privatenumber might want to investigate further.

Might be good to add a comment in the code?

[natemoo-re]

If anyone should apologize, it's me.

No worries! Hard to know if CI changes are going to work until they run... This one would have tripped me up as well.

Right, but prepack is one of many lifecycle scripts called by the package manager. pnpm supports them too.

Yeah I would expect this to work! I'm not sure why prepack wouldn't work, but better safe than sorry I guess?

[natemoo-re]

I'll add a comment!

[ulken]

TIL: https://github.com/pnpm/pnpm/issues/2891

prepack is not user-defined, though, but I wasn't aware of this difference between npm and yarn/pnpm.