Add tutorial button

[kingsamurai123]

Added the external_url code snippet to the manager. Used the "frameInset" texture instead of the "file". This button widget only appears if the entry "external_url" is non-empty.

reference issue: #52

[rikkolovescats]

position of this button will overlap the plugin settings button for plugins that have has_plugin_settings set to True

[kingsamurai123]

ohh. I placed it there as the place below the description is getting filled with "Install/Uninstall", "update", "disable/enable". Let me try out other place holder. thanks for the headsup.

[kingsamurai123]

Moved the button to the right side of the source button with a gap of 10 pixels and barely fitting the small scale UI limit (Used 390 out of 396 pixels).

[Loup-Garou911XD]

The button doesn't look good in my opinion,also the positioning looks weird, it's too much towards the edge

[kingsamurai123]

No worries Loup. I have used the texture, what i thought looked nice even though it shouldn’t be used. As in future, if in case Eric changes the frameInset texture the button would be effected. But for now it is good for me. Since this is our community, we can decide and change. Regarding the position, I couldn’t find other better position for this as the total window is used by other elements. Let me know, if you have a better position in your mind. I am happy to change it. :)

Sent from my iPad

On 01-Feb-2023, at 7:54 PM, Loup @.***> wrote:

 The button doesn't look good in my opinion,also the positioning looks weird, it's too much towards the edge

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[rikkolovescats]

yep, we can always change the position later on @kingsamurai123 there's a PR @Loup-Garou911XD has made on your branch which could be nice to have: https://github.com/kingsamurai123/plugin-manager/pull/2 otherwise this seems ready to merge post fixing metadata md5sum tests and marking this change as version 0.3.0 in index.json

[kingsamurai123]

Wasn't receiving any notifications on my branch hence the delay in the merge on my branch.

Can you please make the window height bigger,it interferes with the discription

Loup you were suggesting to increase the window height so that the button does not interfere with the description. But if we are allowed to change the dimensions of the window, I suggest we increase both sides. So that the button won't appear as close to the edge and as you said button does not interfere with the description. So, should I do it or wait for next change?

[Loup-Garou911XD]

Wasn't receiving any notifications on my branch hence the delay in the merge on my branch.

Can you please make the window height bigger,it interferes with the discription

Loup you were suggesting to increase the window height so that the button does not interfere with the description. But if we are allowed to change the dimensions of the window, I suggest we increase both sides. So that the button won't appear as close to the edge and as you said button does not interfere with the description. So, should I do it or wait for next change?

Yeah let's do it

[rikkolovescats]

let's also mark this change as 0.3.0 instead of 0.2.3 as this is a new feature

[kingsamurai123]

I have Increased the s value by .1 in each scale, so that both height and width gets increased. https://github.com/bombsquad-community/plugin-manager/blob/d07794a05d483bcce9e1d186254b336504846cb8/plugin_manager.py#L819-L821

Now, the window looks fine but still random_join plugin description gets into source button. Should I leave it or make changes appropriately?

Edit: I tried to read the docs of rowwidget but couldn't figure out what it does. So went with this option.

[Loup-Garou911XD]

I have Increased the s value by .1 in each scale, so that both height and width gets increased. https://github.com/bombsquad-community/plugin-manager/blob/d07794a05d483bcce9e1d186254b336504846cb8/plugin_manager.py#L819-L821

Now, the window looks fine but still random_join plugin description gets into source button. Should I leave it or make changes appropriately?

Edit: I tried to read the docs of rowwidget but couldn't figure out what it does. So went with this option.

Rowwidget is like a column widget but for making rows,u can make a row widget and pass it as argument for parent in other widget and they will be aligned in a row by rowwidget

[Loup-Garou911XD]

U can use whatever you are comfortable with, doesn't matter much

[Loup-Garou911XD]

I have Increased the s value by .1 in each scale, so that both height and width gets increased. https://github.com/bombsquad-community/plugin-manager/blob/d07794a05d483bcce9e1d186254b336504846cb8/plugin_manager.py#L819-L821

Now, the window looks fine but still random_join plugin description gets into source button. Should I leave it or make changes appropriately?

Edit: I tried to read the docs of rowwidget but couldn't figure out what it does. So went with this option.

Yeah make changes so it doesn't interfere

[Loup-Garou911XD]

🎉