search

bombsquad-community / plugin-manager

A Plugin Manager for Bombsquad 1.7+
https://bombsquad-community.web.app/pluginmanager
Other
40 stars 29 forks source link

DEPRACTION IN 3.11 #129

Closed brostosjoined closed 11 months ago

brostosjoined commented 1 year ago

https://github.com/bombsquad-community/plugin-manager/blob/97a4a6a244e3bf78366c5f14600c1f2ac4dd8340/plugin_manager.py#L68

Some little headsup @rikkolovescats https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop

rikkolovescats commented 1 year ago

thanks! i don't think any changes should be required in plugin manager since event loop should already be set at all times from here, unless i'm missing something: https://github.com/bombsquad-community/plugin-manager/blob/97a4a6a244e3bf78366c5f14600c1f2ac4dd8340/plugin_manager.py#L2322

brostosjoined commented 1 year ago

Seems perfect good. Closing the issue as complete.

Loup-Garou911XD commented 11 months ago

thanks! i don't think any changes should be required in plugin manager since event loop should already be set at all times from here, unless i'm missing something:

https://github.com/bombsquad-community/plugin-manager/blob/97a4a6a244e3bf78366c5f14600c1f2ac4dd8340/plugin_manager.py#L2322 Screenshot from 2023-10-01 18-23-18

no it isnt

rikkolovescats commented 11 months ago

closed by https://github.com/bombsquad-community/plugin-manager/pull/193