Open rikkolovescats opened 1 year ago
@kingsamurai123 gentle ping, this might interest you :cat:
The plugin retrieves the compatible versions itself while checking for new plugins. https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L336
Doesn't this work? https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L803-L806
At the moment, we consider all plugins in the repo while showing the new plugin notification screenmesage, here: https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L327 https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L350
Instead, we should only be considering plugins that are supported by the current game version. Otherwise, there are cases when the notify new plugin screenmessage doesn't get shown even when there are new plugins available for our game version.