search

bombsquad-community / plugin-manager

A Plugin Manager for Bombsquad 1.7+
https://bombsquad-community.web.app/pluginmanager
Other
39 stars 28 forks source link

Only consider plugins supported by current game version when notifying new plugins #161

Open rikkolovescats opened 1 year ago

rikkolovescats commented 1 year ago

At the moment, we consider all plugins in the repo while showing the new plugin notification screenmesage, here: https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L327 https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L350

Instead, we should only be considering plugins that are supported by the current game version. Otherwise, there are cases when the notify new plugin screenmessage doesn't get shown even when there are new plugins available for our game version.

rikkolovescats commented 1 year ago

@kingsamurai123 gentle ping, this might interest you :cat:

kingsamurai123 commented 11 months ago

The plugin retrieves the compatible versions itself while checking for new plugins. https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L336

Doesn't this work? https://github.com/bombsquad-community/plugin-manager/blob/b90deb6a1dd1562b71f10c6a4fd5eecab6fb63c6/plugin_manager.py#L803-L806