bombsquad-community / plugin-manager

A Plugin Manager for Bombsquad 1.7+
https://bombsquad-community.web.app/pluginmanager
Other
39 stars 28 forks source link

update practice tools to API 8 #179

Closed CrossJoy closed 1 year ago

brostosjoined commented 1 year ago

Are the print statements supposed to ship with the release version of the mod or you used them for debugging and forgot.

CrossJoy commented 1 year ago

Are the print statements supposed to ship with the release version of the mod or you used them for debugging and forgot.

I only edited 1 plugin file and the utilities json. Somehow the others kinda auto generated.

brostosjoined commented 1 year ago

Sorry if you didnt get me i mean this https://github.com/bombsquad-community/plugin-manager/blob/ed22b78564ea71beba16733f4fb6f932116f4c58/plugins/utilities/practice_tools.py#L1135

settings loaded
1
power settings loaded
5
power settings saved
2
power settings saved
2
power settings saved
7
power settings saved
(8, 1, 0)
settings saved
1
power settings saved
(7, 1, 0)
settings saved
CrossJoy commented 1 year ago

Sorry if you didnt get me i mean this

https://github.com/bombsquad-community/plugin-manager/blob/ed22b78564ea71beba16733f4fb6f932116f4c58/plugins/utilities/practice_tools.py#L1135

settings loaded
1
power settings loaded
5
power settings saved
2
power settings saved
2
power settings saved
7
power settings saved
(8, 1, 0)
settings saved
1
power settings saved
(7, 1, 0)
settings saved

oh sry, debugging stuff. U want me to remove them?

brostosjoined commented 1 year ago

Yeah

rikkolovescats commented 1 year ago

@CrossJoy let's add .history to .gitignore and also remove the files that got included from the .history directory, also squashing your commits'll be nice so that these files do not show up in commit history

CrossJoy commented 1 year ago

anything else @rikkolovescats @brostosjoined ?

brostosjoined commented 1 year ago

I think thats all

rikkolovescats commented 1 year ago

i've squashed your commits to not include the unnecessary files into commit history