search

bombsquad-community / plugin-manager

A Plugin Manager for Bombsquad 1.7+
https://bombsquad-community.web.app/pluginmanager
Other
39 stars 28 forks source link

Fixed menu theme for deprecated methods #219

Closed Loup-Garou911XD closed 6 months ago

Freaku17 commented 6 months ago

Error in new ver:

set_main_menu_window() should be passed a 'from_window' value to help ensure proper UI behavior (/storage/emulated/0/Android/data/net.froemling.bombsquad/files/mods/menu_theme.py line 1989).
Loup-Garou911XD commented 6 months ago

Yeah ik that warning, that's what I mentioned in discord

Loup-Garou911XD commented 6 months ago

We can fix that later

Freaku17 commented 6 months ago

We can fix that later

Okay, whenever you feel comfortable 👍

Loup-Garou911XD commented 6 months ago

Yeah so we can merge

Freaku17 commented 6 months ago

Yeah so we can merge

Yes, we can merge after we fix that

Loup-Garou911XD commented 6 months ago

Yeah so we can merge

Yes, we can merge after we fix that

its a warning rn so can we do that in a different pr

Freaku17 commented 6 months ago

its a warning rn so can we do that in a different pr

Imo, since it is related to the current PR it should be done in the current one only & then merged. Will hardly take few min to fix?

Freaku17 commented 6 months ago

This still has a error, but made it easier for you

Loup-Garou911XD commented 6 months ago

Closes #213

Freaku17 commented 6 months ago

@Loup-Garou911XD This still has the following error; I dunno how to fix...

  File "/storage/emulated/0/Android/data/net.froemling.bombsquad/files/mods/menu_theme.py", line 1481, in on_transition_in
    MainMenuWindow(transition=None).get_root_widget(), from_window=self._root_widget
                                                                   ^^^^^^^^^^^^^^^^^
AttributeError: 'MainMenuTheme' object has no attribute '_root_widget'
set_main_menu_window() was passed 'from_window' <bauiv1 'container' widget 0xb40000737e03bd00> but existing main-menu-window is None. (/data/data/net.froemling.bombsquad/no_backup/ballistica_files/ba_data/python/bauiv1lib/mainmenu.py line 1077).
Loup-Garou911XD commented 6 months ago

That's why I asked to fix that in a different commit So that the plugin could be functional while we fix a warning

Loup-Garou911XD commented 6 months ago

Anyways I'll try to fix it today