search

bombsquad-community / plugin-manager

A Plugin Manager for Bombsquad 1.7+
https://bombsquad-community.web.app/pluginmanager
Other
39 stars 28 forks source link

Fixed plugman throwing errors on older builds #220

Closed Loup-Garou911XD closed 6 months ago

Loup-Garou911XD commented 6 months ago

Fixed plugman throwing errors on older builds of api 8 which were caused by addition of the from_window parameter to set_main_menu_window method

also fixed some changed attribute names in compatibility layer

Freaku17 commented 6 months ago

Error in old ver:

Exception in Python call:
  root call: <bound method NewAllSettingsWindow._do_modmanager of <plugin_manager.NewAllSettingsWindow object at 0x73ff46d190>>
  root call origin: plugin_manager.py:2371
  context_ref: empty
Traceback (most recent call last):
  File "/storage/emulated/0/Android/data/net.froemling.bombsquad_/files/mods/plugin_manager.py", line 2520, in _do_modmanager
    bui.app.ui_v1.set_main_menu_window(
TypeError: UIV1Subsystem.set_main_menu_window() got an unexpected keyword argument 'from_window'
Loup-Garou911XD commented 6 months ago

Error in old ver:

Exception in Python call:
  root call: <bound method NewAllSettingsWindow._do_modmanager of <plugin_manager.NewAllSettingsWindow object at 0x73ff46d190>>
  root call origin: plugin_manager.py:2371
  context_ref: empty
Traceback (most recent call last):
  File "/storage/emulated/0/Android/data/net.froemling.bombsquad_/files/mods/plugin_manager.py", line 2520, in _do_modmanager
    bui.app.ui_v1.set_main_menu_window(
TypeError: UIV1Subsystem.set_main_menu_window() got an unexpected keyword argument 'from_window'

Hmm any specific steps to reproduce? Also what's your build version? I couldn't do this, also the code suggests it shouldn't be happening

Freaku17 commented 6 months ago

Hmm any specific steps to reproduce? Also what's your build version? I couldn't do this, also the code suggests it shouldn't be happening

It's the old version (1.7.28), when I opened and closed menu_theme button

Loup-Garou911XD commented 6 months ago

Hmm any specific steps to reproduce? Also what's your build version? I couldn't do this, also the code suggests it shouldn't be happening

It's the old version (1.7.28), when I opened and closed menu_theme button

whats the build version?

Freaku17 commented 6 months ago

whats the build version?

BombSquad 1.7.28 build 21337.

Loup-Garou911XD commented 6 months ago

Error in old ver:

Exception in Python call:
  root call: <bound method NewAllSettingsWindow._do_modmanager of <plugin_manager.NewAllSettingsWindow object at 0x73ff46d190>>
  root call origin: plugin_manager.py:2371
  context_ref: empty
Traceback (most recent call last):
  File "/storage/emulated/0/Android/data/net.froemling.bombsquad_/files/mods/plugin_manager.py", line 2520, in _do_modmanager
    bui.app.ui_v1.set_main_menu_window(
TypeError: UIV1Subsystem.set_main_menu_window() got an unexpected keyword argument 'from_window'

okay this is fixed now

Loup-Garou911XD commented 6 months ago

Closes #212