bombsquad-community / plugin-manager

A Plugin Manager for Bombsquad 1.7+
https://bombsquad-community.web.app/pluginmanager
Other
40 stars 29 forks source link

Replace settings to default plugin setting ui #78

Closed Freaku17 closed 1 year ago

Freaku17 commented 1 year ago

Closes #60

rikkolovescats commented 1 year ago

we'll also have to update existing plugins making use of on_plugin_manager_prompt to these new methods

rikkolovescats commented 1 year ago

also last time i checked show_settings_ui takes a(/an optional?) param, haven't tried it myself but curious how it works and if we'll be missing any of its functionality here in plugin man

Loup-Garou911XD commented 1 year ago

show_settings_ui when being called by ba.Plugin gets a button widget as an argument

Freaku17 commented 1 year ago

also last time i checked show_settings_ui takes a(/an optional?) param, haven't tried it myself but curious how it works and if we'll be missing any of its functionality here in plugin man

I'm so sorry I didn't see that, added those back

rikkolovescats commented 1 year ago

let's mark this as a minor release (0.2.0), and we'll have to update docs for on_plugin_manager_prompt in README

Freaku17 commented 1 year ago

This looks a little messy now, and other PRs are also conflicting.

I'll make a fresh new PR 👍