search

bonaval / sequelize-temporal

Temporal tables for Sequelize
MIT License
82 stars 32 forks source link

Please add another one excluded Name to modelOptions #4

Closed mylawacad closed 5 years ago

mylawacad commented 7 years ago

Sequelize allows to set up tableName when model is defined. Please see documentation link for more details: http://docs.sequelizejs.com/en/latest/docs/models-definition/#configuration

Is there a chance you can add this "tableName" option to the "excludedNames" array, please. Otherwise Temporal turns initial table into a temporal table and so nothing works correctly.

So it would be great if this line will appear in the code: var excludedNames = [ "name", "sequelize", "uniqueKeys", "hasPrimaryKey", "hooks", "scopes", "instanceMethods", "defaultScope", "tableName"];

Instead of this line: var excludedNames = [ "name", "sequelize", "uniqueKeys", "hasPrimaryKey", "hooks", "scopes", "instanceMethods", "defaultScope"];

You did a great job creating this module!!

Many thanks in advance, Andrew

wilzbach commented 7 years ago

Hi @mylawacad

Is there a chance you can add this "tableName" option to the "excludedNames" array, please. Otherwise Temporal turns initial table into a temporal table and so nothing works correctly.

I see your problem, but I am not working for this company anymore nor am I doing a lot of JS development in the last months. Sorry. However, I am happy to guide you through a PR.

You did a great job creating this module!!

Thanks a lot!

ddolcimascolo commented 5 years ago

Apparently done in https://github.com/bonaval/sequelize-temporal/commit/bebc20e21f5e2df8a1d758f66de9573abf533cf8

Closing. Feel free to reopen in case I'm missing the point.