bonclay7 / aws-amicleaner

Cleanup your old unused ami and related snapshots
MIT License
362 stars 132 forks source link

[WIP] Async snaphots delete #16

Closed bonclay7 closed 8 years ago

bonclay7 commented 8 years ago

Deletion of snapshots fails sometimes when the related AMI is not deregistered yet (because deregistering operation is asynchronous). This PR proposes a way to catch those failures, store the failed ids in a state on a cached file on the local dir. On each execution, the tool will look out for the state file and try to remove saved snapshots ids. and simply print those snapshots out An issue has been submitted https://github.com/bonclay7/aws-amicleaner/issues/15

codecov-io commented 8 years ago

Current coverage is 86.93% (diff: 40.00%)

Merging #16 into master will decrease coverage by 1.83%

@@             master        #16   diff @@
==========================================
  Files             5          5          
  Lines           543        551     +8   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            482        479     -3   
- Misses           61         72    +11   
  Partials          0          0          

Powered by Codecov. Last update 6518a50...c1c5285