I found that after a recent upgrade of the daemon, it would no longer build on my CI setup. Digging into the issue, this seems to be due to the new libfaac dependency which I cannot easily satisfy on my CI since it is expected to run entirley on Debian main (no non-free components enabled).
I would thus like to ask for a possibility to build without this new dependency if possible. A proof-of-concept patch is attached. If it is good enough, feel free to include it into the upstream. If not, please tell me if it would be possible to allow for a build without libfaac and what approach you would suggest for implementing it?
Thanks in advance and Kind regards
Linux-Fan (@m7a)
Commit message:
Previously, since the introduction of the streamer support in version 2.0.0, it was impossible to compile the daemon without a dependency on libfaac. This prevented the daemon from being built on Debian systems without non-free repositories enabled. It seems the issue with libfaac is that it is based on code with a non-DFSG compliant license.
This commit introduces a new config option WITH_STREAMER which is ON by default, causing the behaviour to stay backwards-compatible with the one before this commit. It is newly possible to pass -DWITH_STREAMER=OFF to cmake to build without streamer support and without the dependency on libfaac.
I found that after a recent upgrade of the daemon, it would no longer build on my CI setup. Digging into the issue, this seems to be due to the new
libfaacdependency which I cannot easily satisfy on my CI since it is expected to run entirley on Debianmain(no non-free components enabled).I would thus like to ask for a possibility to build without this new dependency if possible. A proof-of-concept patch is attached. If it is good enough, feel free to include it into the upstream. If not, please tell me if it would be possible to allow for a build without libfaac and what approach you would suggest for implementing it?
Thanks in advance and Kind regards Linux-Fan (@m7a)
Commit message: