Performance Analysis

[bonedaddy]

CPU Profiles

1

This I recorded on my RPi3 doing a simple wifi network scan, no associations or any deauths

Notable mentions:

• The WiFi module stationPrunner spends a lot of time sleeping
• WiFi module stationPrunner, channelHopper spend some measurable time allocating slices
• EventStream module View function spends a lot of time printing

2

This I recorded on my RPi3 doing a simple network scan, along with mass association every 5 seconds via ticker

Notable mentions:

• WiFi module stationPrunner spends measurable time within list

Memory Profiles

1

Captured alongside #2 from cpu profiles

[bonedaddy]

Possible Improvements

• https://github.com/bonedaddy/bettercap/blob/master-blaster/modules/wifi/wifi_hopping.go#L98
  • This can be adjusted to use NewTimer and call stop
  • However due to the way its used, we can probably refactor this function to use a ticker, and it would be vastly more efficient

General Comments

• There are repeated lookups to check for binaries. For example everytime a channel hop occurs, we lookup whether or not the binaries exist to allow us to trigger a channel hop. This is a bit redundant, as we can pre-populate this lookup table once at startup. This would likely lead to massively faster channel hoping.

Slice Optimization Of Functions like Stations::List

try slice = slice[:0]  that truncates slice and leaves allocated space
so you can append egan