search

boneskull / angular-tags

Pure AngularJS tagging widget with typeahead support courtesy of ui-bootstrap
MIT License
133 stars 32 forks source link

fixed bower.json dependency names to be the common uses #50

Closed christrude closed 9 years ago

christrude commented 9 years ago

Please allow this pull request to go through. Causing a lot of problems at build time with grunt package injection with duplicity of components.

boneskull commented 9 years ago

bootstrap-css will be eliminated (at some point). Using bootstrap proper pulls in a bunch of JavaScript files we don't need. I'm not sure why you need it or are using it alongside ui-bootstrap.

I would accept this PR with line 9 reverted.

christrude commented 9 years ago

See that'd be great if bootstrap-css as a dependency only pulled the css files, but it doesn't, it pulls basically the bootstrap dist folder. The problem with this is that most people are already including bootstrap, and this creates a second dependency as bootstrap-css, bloating the asset stack, and if you use grunt-bower-install in your build scheme, it will put multiple instances of bootstrap file dependencies in the index.html file. It' just causing duplicates. I see what you mean though. You don't have to accept it.

On Tue, Oct 14, 2014 at 2:51 PM, Christopher Hiller < notifications@github.com> wrote:

bootstrap-css will be eliminated (at some point). Using bootstrap proper pulls in a bunch of JavaScript files we don't need. I'm not sure why you need it or are using it alongside ui-bootstrap.

I would accept this PR with line 9 reverted.

— Reply to this email directly or view it on GitHub https://github.com/boneskull/angular-tags/pull/50#issuecomment-59122971.

boneskull commented 9 years ago

If "most people" are including all of bootstrap just to use ui-bootstrap, most people are doing it wrong.

Especially when using grunt-wiredep (which is either the successor to grunt-bower-install or just a rename; not sure)--this will include bootstrap.js in your HTML.

You're right about bootstrap-css. A better package would be bootstrap-css-only, I imagine.

Regardless, I'm going to eliminate any "css" dependencies from this package (at some point) or someone can help me do it.

boneskull commented 9 years ago

I'm going to close this if you don't wish to make the requested change. Thanks!