bonesoul / CoiniumServ

Next-gen crypto currency mining pool software
Other
795 stars 493 forks source link

Hashed mining pubkey validation - some pubkey/privkeys don't derive same address #524

Closed fedaykinofdune closed 10 years ago

fedaykinofdune commented 10 years ago

I apologize if this issue is known, I've looked through a great many issue reports here and there, but so far haven't really came across anyone with my issue. I haven't had the time to dig deep enough to figure out where the fault lies with hashed mining keys, I'm assuming miners riding the coin switch will be using a hashed pubkey similar as with NOMP. Not sure if it's an issue with the script that's included with nomp but we've had issues with the generator, the pubkey seems to deterministically come up with a proper address, but the privkey provided does not generate the same address, much to our dismay after a lot of mining and a lot of hacking around trying to get the hashed privkey to come up with the address the pubkey mines to. Anyway, if one is using a hashed key for mining, will there be some sort of key validation measures in place to make sure people avoid issues such as I described? Even if Coinium includes its own key generator I would imagine that many folks would still be re-using their own keys that may have been generated by nomp's script, of which so far I've managed to generate 3 different keys that don't match up properly on some coins. Two of the three failed to work with Dogecoin, DogecoinDark, and another "D" address coin (don't remember which), while they worked fine on some others I tried out, and one that worked fine with "D" coins and some others, but didn't work with Carboncoin and Octocoin. Spent many, many hours running the keys through various paces, different base58check address versions and many different key derivation scripts I've found around github. If someone encounters this, it's one of those things that may not be apparent until it's too late, you've mined you up a nice stash only to find you cannot spend it! As a pool owner this greatly concerns me as I do my best to provide pools that are easy to use, both for the newbie or the enthusiast, and provide a guaranteed high standard of service and reliability.

I've taken several shots at it, if the devs here would like the errant keys for research and troubleshooting purposes, let me know, I'll need to make double sure my partner isn't using them for anything else. There's a pretty nice chunk of DogecoinDark tied up in one of the keys, so a bounty, maybe?

bonesoul commented 10 years ago

fedaykintune, CoiniumServ doesn't use a similar scheme to nomp where it does derive keys from pubkeys of miners.

Our auto-exchange will be not using that functionality but a miner would be able to just use his address from expected currency address to get in multi-pool port.

bonesoul commented 10 years ago

Closing the issue, @fedaykinofdune if you still think this is an issue please ping back so we can re-open it.