bonesoul / CoiniumServ

Next-gen crypto currency mining pool software
Other
798 stars 494 forks source link

miner socket keep connected with empty or invalid wallet address #636

Open frndxyz opened 10 years ago

frndxyz commented 10 years ago

in my pool i see some of bot miner are making overload to server by keep alive the socket and do nothing. and some of miner with invalid address is not authenticated but socket is alived.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

frndxyz commented 10 years ago

can i change authetication code like this??

        if (!miner.Authenticated)
        {
            ((IClient)miner).Connection.Disconnect();
            return;
        }
frndxyz commented 10 years ago

or i think for bot miners that just making a overload. we must have some authentication timeout. if socket is not authenticate before timeout we just disconnect the miner.