search

bonesoul / voxeliq

voxeliq is an open source block-based game engine implementation developed with C#
http://www.int6.org/tag/voxeliq
Microsoft Public License
163 stars 43 forks source link

Refactor out the Logger configuration. #45

Open bonesoul opened 11 years ago

bonesoul commented 11 years ago

As this isn't any kind of server-like software, I don't think we need configurable loggers. So I'll be refactoring out logger configuration functionality -- and will bind the console and file log will be just statically.

bonesoul commented 11 years ago

initial work: https://github.com/raistlinthewiz/voxeliq/commit/d36333d7785ef573033d3a180e83bc5941e63b0b

Delwin9999 commented 11 years ago

I'm always loathe to remove functionality and configurable loggers are wonderful for runtime debugging.

That said the overhead may not be worth it.

bonesoul commented 11 years ago

With the latest commit, I left them as still configurable ones.

Loggers are already initialized by the sample game where modifying the game.cs code and configuring them in-code is just similar to configuring them from the ini file.

And for release builds, I don't think anyone will be willing to let their users to configure game-clients logging functionality from the ini.