bonfire-networks / bonfire-app

Bonfire - tend to your digital life in community. Customise and host your own online space and control your experience at the most granular level.
https://bonfirenetworks.org
GNU Affero General Public License v3.0
522 stars 37 forks source link

Update test CI #856

Closed fishinthecalculator closed 4 months ago

mayel commented 4 months ago

Thanks for this, looks great! Only wondering about any pros/cons between manually installing docker vs using native container support like:


services:
      postgres:
        image: postgis/postgis:12-3.3-alpine
fishinthecalculator commented 4 months ago

Thanks for this, looks great! Only wondering about any pros/cons between manually installing docker vs using native container support like:

services:
      postgres:
        image: postgis/postgis:12-3.3-alpine

I don't have a clear opinion on this topic. The rationale for having commands run from the justfile is that imho CI should run as close as possible to what we run in the CLI upon developing. This way as soon as the justfile is broken somehow CI also breaks and it also avoids duplicating implementation between the CI job and the development environment setup. If you have a different opinion I'd love to hear it!

EDIT: The real solution imo would be to switch to nix for everything but it is a substantial investment and i don't think it is worth at this point

mayel commented 4 months ago

@fishinthecalculator it may be relevant that git-publish.sh is used to push regular commits, not only when releasing a new version, so not sure if creating the tag there makes sense?

fishinthecalculator commented 4 months ago

@mayel thank you for the heads up, i had some rethinking about how to proceed. i'm starting to think that this MR should just be split between the test and the release part. I didn't remember about the contrib-release command you told me about until today and i wanted to start a discussion about how to stabilize the main branch

OT: is there some chat or some synchronous media where you hang out to talk about bonfire if I have some quick technical question? should I use https://campground.bonfire.cafe ?

mayel commented 4 months ago

sounds good! there's https://matrix.to/#/%23bonfire-tech%3Amatrix.org

mayel commented 4 months ago

Should we merge this one and then go from there?

fishinthecalculator commented 4 months ago

Yes I agree