search

bonfire-networks / bonfire-app

Bonfire - tend to your digital life in community. Customise and host your own online space and control your experience at the most granular level.
https://bonfirenetworks.org
GNU Affero General Public License v3.0
522 stars 37 forks source link

Bug: reply remotely not working on demo site #921

Closed adrigen closed 1 month ago

adrigen commented 1 month ago

Describe the bug I hit reply on the demo site whilst logged out and there is an error once I submit my email

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://campground.bonfire.cafe/'
  2. Click on 'reply' after a message
  3. it asks for an email address enter 'bold.iron0109@fastmail.com'

Expected behavior Get a white screen with 'Sorry, your actor or remote interaction URL was not found'

Bonfire environment (please complete the following information): this is the online demo: https://campground.bonfire.cafe/pub/remote_interaction

Device (please complete the following information):

mayel commented 1 month ago

Hello, thanks for the report, please note that feature expects an fediverse / ActivityPub username rather than an email. Maybe we need to clarify that in the copy.

adrigen commented 2 weeks ago

there should be validation on the input, right?

ivanminutillo commented 2 weeks ago

yes @adrigen, and there are also some weird behaviours with phx-ignore on some fields (eg. the title disappear if the user focus or click other buttons)

mayel commented 2 weeks ago

An ActivityPub actor is indistinguishable from an email address though, until we actually try to query for it with WebFinge and not get a valid response, which is what that error message is saying.