bonfire-networks / bonfire-app

Bonfire - tend to your digital life in community. Customise and host your own online space and control your experience at the most granular level.
https://bonfirenetworks.org
GNU Affero General Public License v3.0
521 stars 37 forks source link

incoming notification breaks the instance? #944

Open ivanminutillo opened 4 days ago

ivanminutillo commented 4 days ago

When there's an incoming notification from a remote user, i get a (possible) infinite loop like this:

 12:42:37.537 request_id=F960fKUSJxiFYqUAA6wR [warning] skip verifying signature for GET and `reject_unsigned?` set to : false
?2024-07-03T12:42:38.370081962Z     ActivityPub.Web.Plugs.HTTPSignaturePlug.call/2 @ deps/activity_pub/lib/web/plugs/http_signature_plug.ex:62
s2024-07-03T12:42:38.370089282Z     Bonfire.Web.Router.signed_activity_pub_fetch/2 @ deps/bonfire/lib/web/router.ex
p2024-07-03T12:42:38.370094573Z     Bonfire.Web.Router.__pipe_through18__/1 @ deps/bonfire/lib/web/router.ex:299
f2024-07-03T12:42:38.370099649Z     Phoenix.Router.__call__/5 @ deps/phoenix/lib/phoenix/router.ex:475
q2024-07-03T12:42:38.370104372Z     Bonfire.Web.Endpoint.plug_builder_call/2 @ deps/bonfire/lib/web/endpoint.ex:1
 2024-07-03T12:42:38.370108694Z 
?2024-07-03T12:42:38.391287268Z 12:42:37.539 request_id=F960fKh2BfPUqloAA6xx [warning] skip verifying signature for GET and `reject_unsigned?` set to : false
?2024-07-03T12:42:38.391352791Z     ActivityPub.Web.Plugs.HTTPSignaturePlug.call/2 @ deps/activity_pub/lib/web/plugs/http_signature_plug.ex:62
s2024-07-03T12:42:38.391359883Z     Bonfire.Web.Router.signed_activity_pub_fetch/2 @ deps/bonfire/lib/web/router.ex
p2024-07-03T12:42:38.391364738Z     Bonfire.Web.Router.__pipe_through19__/1 @ deps/bonfire/lib/web/router.ex:299
f2024-07-03T12:42:38.391369661Z     Phoenix.Router.__call__/5 @ deps/phoenix/lib/phoenix/router.ex:475
q2024-07-03T12:42:38.391374805Z     Bonfire.Web.Endpoint.plug_builder_call/2 @ deps/bonfire/lib/web/endpoint.ex:1
 2024-07-03T12:42:38.391380023Z 
?2024-07-03T12:42:38.411930771Z 12:42:37.539 request_id=F960e1RuoyjRs9UAA43R [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire_me
?2024-07-03T12:42:38.411977057Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.411982270Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.411986439Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.411990895Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
~2024-07-03T12:42:38.411994818Z     Bonfire.Common.Extend.module_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:162
 2024-07-03T12:42:38.411998668Z 
2024-07-03T12:42:38.422332462Z 12:42:37.540 request_id=F960dQUSBjUzek4AAyYR [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire_ui_reactions
?2024-07-03T12:42:38.422394135Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.422401498Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.422407292Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.422412859Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
~2024-07-03T12:42:38.422418355Z     Bonfire.Common.Extend.module_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:162
 2024-07-03T12:42:38.422422912Z 
?2024-07-03T12:42:38.426042657Z 12:42:37.543 request_id=F960e6pRkoI-Y5gAA5TR [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire_me
?2024-07-03T12:42:38.426076285Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.426091930Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.426096602Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.426100634Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
?2024-07-03T12:42:38.426104516Z     Bonfire.Common.Extend.do_is_extension_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:186
 2024-07-03T12:42:38.426108442Z 
?2024-07-03T12:42:38.428346399Z 12:42:37.549 request_id=F960e_ql-vP9rWkAA51h [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire_me
?2024-07-03T12:42:38.428375825Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.428380382Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.428384454Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.428399295Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
~2024-07-03T12:42:38.428403714Z     Bonfire.Common.Extend.module_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:162
 2024-07-03T12:42:38.428407712Z 
f2024-07-03T12:42:38.430159829Z 12:42:37.551 request_id=F960e_uFYXtpvh0AA52R [info] Sent 200 in 5255ms
n2024-07-03T12:42:38.430889961Z 12:42:37.558 request_id=F960fTU2v5YWbkYAA7QR [info] GET /.well-known/webfinger
?2024-07-03T12:42:38.431560768Z 12:42:37.576 request_id=F960fHPArMWpX2cAA6gh [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire
?2024-07-03T12:42:38.431601891Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.431606640Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.431610681Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.431614675Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
?2024-07-03T12:42:38.431618510Z     Bonfire.Common.Extend.do_is_extension_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:186
 2024-07-03T12:42:38.431622373Z 
n2024-07-03T12:42:38.433112402Z 12:42:37.594 request_id=F960fTdV0LBv9eEAA7Qh [info] GET /.well-known/webfinger
?2024-07-03T12:42:38.433799842Z 12:42:37.599 request_id=F960fIXc6VeW5RUAA6nB [warning] Skip creating a Peered for local URI: https://ivan.cafe/pub/actors/ivan
?2024-07-03T12:42:38.433816945Z     Bonfire.Federate.ActivityPub.Peered.get_or_create/2 @ deps/bonfire_federate_activitypub/lib/peer/peered.ex:85
?2024-07-03T12:42:38.433821418Z     Bonfire.Federate.ActivityPub.Peered.is_blocked?/3 @ deps/bonfire_federate_activitypub/lib/peer/peered.ex:172
?2024-07-03T12:42:38.433825516Z     Bonfire.Federate.ActivityPub.BoundariesMRF.actor_blocked?/3 @ deps/bonfire_federate_activitypub/lib/boundaries/boundaries_mrf.ex:597
?2024-07-03T12:42:38.433849421Z     Bonfire.Federate.ActivityPub.Adapter.federate_actor?/3 @ deps/bonfire_federate_activitypub/lib/adapter/adapter.ex:421
?2024-07-03T12:42:38.433854587Z     ActivityPub.Web.ActivityPubController.federate_actor?/2 @ deps/activity_pub/lib/web/controllers/activity_pub_controller.ex:248
 2024-07-03T12:42:38.433858677Z 
q2024-07-03T12:42:38.435477920Z 12:42:37.640 request_id=F960fQxAog-cO9kAA7JB [info] Request from ::ffff:10.0.1.12
?2024-07-03T12:42:38.436163349Z 12:42:37.648 request_id=F960fBVGgHQq1CYAA6AR [info] request from: "::ffff:10.0.1.12" / ["http.rb/5.1.1 (Mastodon/4.2.9; +https://defcon.social/)"] @ ActivityPub.Utils.json_with_cache/6 @ deps/activity_pub/lib/utils.ex:348
?2024-07-03T12:42:38.436822025Z 12:42:37.653 request_id=F960fNpknOOj6OIAA6-R [info] HTTPSignaturePlug @ ActivityPub.Web.Plugs.HTTPSignaturePlug.call/2 @ deps/activity_pub/lib/web/plugs/http_signature_plug.ex:18
r2024-07-03T12:42:38.437437714Z 12:42:37.653 request_id=F960fTrf7pOHWA4AA7RB [info] GET /pub/actors/ivan/followers
?2024-07-03T12:42:38.438011328Z 12:42:37.666 request_id=F960fN--GonTsuMAA7AB [info] HTTPSignaturePlug @ ActivityPub.Web.Plugs.HTTPSignaturePlug.call/2 @ deps/activity_pub/lib/web/plugs/http_signature_plug.ex:18
2024-07-03T12:42:38.465479343Z 12:42:37.656 request_id=F960fTsGnoZIt8sAA7RR [info] GET /pub/objects/01J1W9A6X14BMKP8EN80WQY558
?2024-07-03T12:42:38.522034420Z 12:42:37.682 request_id=F960fEveoz_9CKkAA6WB [warning] ---------> Possible n+1 query detected! Number of occurrences: 2 SQL query: ok db=5ms source="bonfire_data_activity_pub_peered"
?2024-07-03T12:42:38.522084139Z   SELECT b0."id", b0."peer_id", b0."canonical_uri", b0."id" FROM "bonfire_data_activity_pub_peered" AS b0 WHERE (b0."id" = '01J1W717XFSMVXJ3BK344ZX3EE') 
 2024-07-03T12:42:38.522109819Z 
?2024-07-03T12:42:38.583145789Z 12:42:37.682 request_id=F960fDuCVYym6egAA6NB [warning] ---------> Possible n+1 query detected! Number of occurrences: 2 SQL query: ok db=5ms source="bonfire_data_activity_pub_peered"
?2024-07-03T12:42:38.583207208Z   SELECT b0."id", b0."peer_id", b0."canonical_uri", b0."id" FROM "bonfire_data_activity_pub_peered" AS b0 WHERE (b0."id" = '01J1W717XFSMVXJ3BK344ZX3EE') 
 2024-07-03T12:42:38.583213629Z 
f2024-07-03T12:42:38.599187845Z 12:42:37.683 request_id=F960fNf8_arA6z8AA69h [info] Sent 200 in 1688ms
f2024-07-03T12:42:38.602068004Z 12:42:37.683 request_id=F960fN1Qi5TPxWQAA6-h [info] Sent 200 in 1599ms
f2024-07-03T12:42:38.614604294Z 12:42:37.683 request_id=F960fOVumiruGK0AA7Dx [info] Sent 200 in 1463ms
?2024-07-03T12:42:38.629189038Z 12:42:37.689 request_id=F960e4AzC3stN1IAA5HB [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire_me
?2024-07-03T12:42:38.629237053Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.629242442Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.629246564Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.629250516Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
~2024-07-03T12:42:38.629254400Z     Bonfire.Common.Extend.module_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:162
 2024-07-03T12:42:38.629258440Z 
?2024-07-03T12:42:38.645706124Z 12:42:37.690 request_id=F960fB4zX0OrRCkAA6Bx [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire_me
?2024-07-03T12:42:38.645769317Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.645776425Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.645781060Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.645785708Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
~2024-07-03T12:42:38.645789736Z     Bonfire.Common.Extend.module_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:162
 2024-07-03T12:42:38.645793652Z 
?2024-07-03T12:42:38.649057466Z 12:42:37.691 request_id=F960e7_h_pQsd0sAA5Yx [warning] You should pass a current_user and/or current_account (with settings assoc preloaded) in `opts` depending on what scope of Settings you want for OTP app: :bonfire_me
?2024-07-03T12:42:38.649089980Z     Bonfire.Common.Settings.fetch_all_scopes/2 @ deps/bonfire_common/lib/config_settings/settings.ex:135
?2024-07-03T12:42:38.649103875Z     Bonfire.Common.Settings.get_merged_ext/2 @ deps/bonfire_common/lib/config_settings/settings.ex:101
z2024-07-03T12:42:38.649124609Z     Bonfire.Common.Settings.get/3 @ deps/bonfire_common/lib/config_settings/settings.ex:36
{2024-07-03T12:42:38.649128893Z     Bonfire.Common.Extend.is_disabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:211
?2024-07-03T12:42:38.649134064Z     Bonfire.Common.Extend.do_is_extension_enabled?/2 @ deps/bonfire_common/lib/modularity/extend.ex:186