search

bonfire-xmpp / bonfire

A modern XMPP client
GNU General Public License v2.0
4 stars 0 forks source link

Roster gets deleted every so often #34

Closed misterupkeep closed 3 years ago

misterupkeep commented 3 years ago

Occasionally, SET_ROSTER gets called with an empty array. This manifests at the moment with a cascade failure, resulting in UserCard accessing the property of an undefined, crashing the app.

image

The mutation is called in two (3) places, all in plugins/stanza.js, so this can happen because of two reasons:

  1. bind() is triggered with a session resumption, and getRoster() -- as it's known to -- gets an empty array
  2. iq:set:roster has two identical handlers, maybe they race condition somehow?
misterupkeep commented 3 years ago

Most consistently happens when disconnected from server and navigating between chats: roster gets cleared.

misterupkeep commented 3 years ago

This hasn't happened to me in a while. Did fa4b783's revert of infinite scrollback fix it?