search

bonifaido / rust-zookeeper

Pure Rust library for Apache ZooKeeper built on MIO
MIT License
206 stars 46 forks source link

warning fixes #60

Closed krojew closed 5 years ago

bonifaido commented 5 years ago

Sorry, I have to fix the Travis config, I guess the Java version has changed here.

krojew commented 5 years ago

@bonifaido it would be a good idea to not explicitly use java for testing, but rather the official ZK docker image.

bonifaido commented 5 years ago

The Java-based class represents a multi-node cluster, which covers more code paths (reconnection to next server for example). If this can be achieved with the Docker version I'm happy to change it.

bonifaido commented 5 years ago

I'm fixing the test for now in https://github.com/bonifaido/rust-zookeeper/pull/61

krojew commented 5 years ago

@bonifaido docker based approach gives you the possibility to do whatever you wish, just as with the native approach. You simply don't need to depend on anything other installed than docker.